Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - fallback not working without message store #97

Closed
razorness opened this issue Aug 14, 2017 · 5 comments
Closed

i18n - fallback not working without message store #97

razorness opened this issue Aug 14, 2017 · 5 comments
Assignees
Labels
bug lib-i18n Internationalization/Localization
Projects

Comments

@razorness
Copy link

When you have no message store , falling back to default locale does not work.
When you create an empty file like i18n/messages.de default/fallback does work.

How to reproduce?

  • Install current version of aah framework
  • Intialize new project
  • Execute aah run
  • Open http://localhost:8080/ with f.e. german browser

Result

  • Log output: WARN Locale (de-DE, de) doesn't exists in message store
  • {{ i18n . "label.pages.app.index.title" }} in views/pages/app/index.htmlwill be empty

Environment

  • Windows 10 x64
  • Go 1.8.3
  • Google Chrome 60.0.3112.90 x64 (request header: Accept-Language:de-DE,de;q=0.8,en-US;q=0.6,en;q=0.4)
@jeevatkm jeevatkm self-assigned this Aug 14, 2017
@jeevatkm
Copy link
Member

I will analysis and get back to you, thank you for reporting it.

@jeevatkm
Copy link
Member

@razorness I found it, I will fix and let you know.

@jeevatkm jeevatkm added bug lib-i18n Internationalization/Localization and removed analysis labels Aug 14, 2017
@jeevatkm jeevatkm added this to v0.8 - In Progress in aah Roadmap Aug 14, 2017
jeevatkm added a commit to go-aah/i18n that referenced this issue Aug 14, 2017
jeevatkm added a commit to go-aah/i18n that referenced this issue Aug 14, 2017
@jeevatkm
Copy link
Member

Bug is fixed and i18n v0.3 library is released. Please take an update using below commands.

go get -u aahframework.org/i18n.v0
go install aahframework.org/tools.v0/aah

To check the i18n version

aah -v

@jeevatkm jeevatkm moved this from v0.8 - In Progress to Released to Audience in aah Roadmap Aug 14, 2017
@razorness
Copy link
Author

Works like a charm. :)
Thank you very much.

@jeevatkm
Copy link
Member

@razorness you're welcome.

@jeevatkm jeevatkm modified the milestone: v0.8 Milestone Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug lib-i18n Internationalization/Localization
Projects
aah Roadmap
  
Released to Audience
Development

No branches or pull requests

2 participants