Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max Request Body Size #83

Closed
jeevatkm opened this issue Jul 26, 2017 · 5 comments
Closed

Max Request Body Size #83

jeevatkm opened this issue Jul 26, 2017 · 5 comments
Assignees
@jeevatkm
Labels
aah Framework scope feature lib-router Request Routing
Projects
aah Roadmap
Milestone
v0.8 Milestone

Comments

@jeevatkm
Copy link
Member

It is recommend to limit request body size with sane size value. It prevents the application from

Avoiding DDoS attacks caused by large HTTP request bodies by enforcing a hard limit in your server

Goal is to provide Max Request Body Size for all routes (aka global limit) and individual routes too.
@jeevatkm jeevatkm self-assigned this Jul 26, 2017
@jeevatkm jeevatkm added this to v0.8 Iteration (Not started) in aah Roadmap Jul 29, 2017
@jeevatkm jeevatkm modified the milestone: v0.8 Milestone Jul 29, 2017
@jeevatkm jeevatkm moved this from v0.8 Iteration to v0.8 - In Progress in aah Roadmap Aug 4, 2017
@adelowo
Copy link
Contributor

adelowo commented Aug 4, 2017 •
edited

Hi @jeevatkm, I should be able to work on this next week (if you don't already have it done 😄 )

@jeevatkm
Copy link
Member Author

jeevatkm commented Aug 5, 2017 •
edited

@adelowo This is for Body size limit not a HTTP Headers size limit.

Always welcome to implement, I can explain the design to you.

@jeevatkm
Copy link
Member Author

jeevatkm commented Aug 5, 2017

@adelowo Currently I'm working on content negotiation #75

@adelowo
Copy link
Contributor

adelowo commented Aug 5, 2017 •
edited

Lol, I am sorry I mixed it up. Wasn't thinking straight, I thought i saw an issue related to headers (maybe it wasn't this repo).

jeevatkm added a commit to go-aah/router that referenced this issue Aug 7, 2017
@jeevatkm
go-aah/aah#83 added max body size option for individual route
c0e0f65
jeevatkm added a commit that referenced this issue Aug 7, 2017
@jeevatkm
request max body size limit implementation #83
afe6833
@jeevatkm jeevatkm added aah Framework scope lib-router Request Routing labels Aug 7, 2017
jeevatkm added a commit to go-aah/tools that referenced this issue Aug 7, 2017
@jeevatkm
go-aah/aah#83 max body size config template update
7607551
jeevatkm added a commit to go-aah/docs that referenced this issue Aug 8, 2017
@jeevatkm
doc added for go-aah/aah#75 and go-aah/aah#83
39d081c
jeevatkm added a commit that referenced this issue Aug 9, 2017
@jeevatkm
#83 request max body size limit implementation (#94)
0584709
@jeevatkm
Copy link
Member Author

jeevatkm commented Aug 9, 2017

Implemented and merged :)

@jeevatkm jeevatkm closed this as completed Aug 9, 2017
@jeevatkm jeevatkm moved this from v0.8 - In Progress to Done in aah Roadmap Aug 9, 2017
@jeevatkm jeevatkm moved this from Released to Audience to v0.8 - Completed in aah Roadmap Aug 10, 2017
jeevatkm added a commit to go-aah/docs that referenced this issue Aug 11, 2017
@jeevatkm
go-aah/aah#83 docs updated
64f04a3
jeevatkm added a commit to go-aah/tools that referenced this issue Aug 11, 2017
@jeevatkm
go-aah/aah#83 app template config update
a488c67
@jeevatkm jeevatkm moved this from v0.8 - Completed to Released to Audience in aah Roadmap Sep 3, 2017
jeevatkm added a commit to go-aah/app-templates that referenced this issue Jul 4, 2018
@jeevatkm
go-aah/aah#83 max body size config template update
10517d6
jeevatkm added a commit to go-aah/app-templates that referenced this issue Jul 4, 2018
@jeevatkm
go-aah/aah#83 app template config update
a6064d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
aah Framework scope feature lib-router Request Routing
Projects
aah Roadmap
  
Released to Audience
Milestone
v0.8 Milestone
Development

No branches or pull requests
2 participants
@jeevatkm @adelowo