Add convenient method to save uploaded multi-part file

[jeevatkm]

Add convenient method to save uploaded multi-part file from the request. Currently aah user can has easily access uploaded file via Req.FormFile(key). However it would be good to have following methods on Request struct:

SaveFile(key, dstFile string) error
// e.g.: SaveFiles("avatar_pic", "/mnt/uploads/avatars/username.png")

SaveFiles(key, dstPath string) []error // uses the request filename
// e.g.: SaveFiles("files", "/mnt/uploads")

So that aah user simply call. Example of SaveFile method as follows:

func (u *UploadController) Upload() {
	// Create destination filepath based on your logic
	destFile := "/mnt/uploads/avatars/username.png"

	if err := u.Req.SaveFile("avatar_pic", destFile); err {
		log.Error(err)
		u.Reply().BadRequest().Text("Upload file error: %s", err.Error())
		return
	}

	u.Reply().Ok().Text("Avatar picture uploaded successfully.")
}

[adelowo]

I can work on this but should SaveFile() really be on the Request struct ?

[jeevatkm]

Where do you feel is appropriate to put it? Please let me know your thoughts.

[adelowo]

Not too sure but may be something like this could work ?

//Bad naming
type FileUpload struct {}

func (f *FileUpload) Upload (r *http.Request, key, destFile string) error {
}

The main reason for this is to reduce the size of Req.. I feel there is too much stuff on that struct

[jeevatkm]

Aim is to provide easy use and less memory allocation. If we create struct and provide implementation passing req instance then is it utility method.

I see one more spot other then Request is Context struct.

u.SaveFile("avatar_pic", destFile)

We can go with Context struct. I will update the design description.

[adelowo]

Not to troll but it seems better placed on the Request than Context 😄 ... It is all up to you though..

Context or Request ? I should still be able work on the implementation

[jeevatkm]

Okay 😄 let's go with Request then. That's what I thought of better place.

I will update the design. Also please let me know if you have time after this implementation.

[jeevatkm]

It's done.