Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OnPreShutdown Extension point #185

Closed
2 tasks done
jeevatkm opened this issue May 21, 2018 · 1 comment
Closed
2 tasks done

Add OnPreShutdown Extension point #185

jeevatkm opened this issue May 21, 2018 · 1 comment
Assignees
@jeevatkm
Labels
enhancement server aah Go Server
Projects
aah Roadmap
Milestone
v0.11.0 Milestone

Comments

@jeevatkm
Copy link
Member

jeevatkm commented May 21, 2018 •
edited

The goal is to add new OnPreShutdown extension point in the HTTP engine.

Current Flow:

  • Receive SIGINT/SIGTERM
  • Trigger graceful shutdown with configured timeout on aah server
  • Publish OnShutdown
  • Clean exit

After this enhancement, the flow would be:

  • Receive SIGINT/SIGTERM
  • Publish OnPreShutdown
  • Trigger graceful shutdown with configured timeout on aah server
  • Publish OnShutdown
  • Clean exit
  • Implementation
  • Documentation
@jeevatkm jeevatkm added enhancement server aah Go Server labels May 21, 2018
@jeevatkm jeevatkm added this to the v0.11.0 Milestone milestone May 21, 2018
@jeevatkm jeevatkm self-assigned this May 21, 2018
@jeevatkm jeevatkm added this to v0.11.0 - Iteration in aah Roadmap via automation May 21, 2018
jeevatkm added a commit that referenced this issue May 25, 2018
@jeevatkm
#185 added OnPreShutdown event into the flow
6b31119
@jeevatkm jeevatkm moved this from v0.11.0 - Iteration to v0.11.0 - In Progress in aah Roadmap May 25, 2018
jeevatkm added a commit to go-aah/docs that referenced this issue May 27, 2018
@jeevatkm
go-aah/aah#185 and go-aah/aah#181 doc update
1f37ba3
@jeevatkm
Copy link
Member Author

It done 😄

aah Roadmap automation moved this from v0.11.0 - In Progress to v0.11.0 - Completed May 27, 2018
jeevatkm added a commit that referenced this issue May 27, 2018
@jeevatkm
godoc update and #185 event updates
47b8160
jeevatkm added a commit that referenced this issue May 27, 2018
@jeevatkm
godoc update and #185 event updates
eabbd8c
@jeevatkm jeevatkm moved this from v0.11.0 - Completed to Released to Audience in aah Roadmap Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
enhancement server aah Go Server
Projects
aah Roadmap
  
Released to Audience
Milestone
v0.11.0 Milestone
Development

No branches or pull requests
1 participant
@jeevatkm